Skip to content

Conversation

vfalconisumo
Copy link

When running local:commitAndPush, Terminus throws an exception because commitAndPush expects to return a string, but the function actually returns a void because it lacks a return statement.

This exception breaks our CI pipeline because it throws on both successful and unsuccessful runs of commitAndPush, and suppressing the error would end up hiding legitimate errors.

@vfalconisumo vfalconisumo requested a review from a team as a code owner September 18, 2025 22:20
@stevector stevector assigned pwtyler and greg-1-anderson and unassigned pwtyler Sep 22, 2025
@stevector
Copy link
Contributor

@greg-1-anderson will review/merge assuming tests pass.

@pwtyler
Copy link
Member

pwtyler commented Sep 23, 2025

I tried to push a changelog note but only succeeded in creating a new branch instead. @vfalconisumo (or someone here who knows how to use GitHub better than me 🤦🏻 ), could you pull in the commits here to the forked branch (or just push a new log update)?

@vfalconisumo
Copy link
Author

@pwtyler I believe I was able to pull those commits into my branch this morning. Let me know if I failed miserably though :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants