Address PHP exception on local:commitAndPush
#2723
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When running
local:commitAndPush
, Terminus throws an exception becausecommitAndPush
expects to return a string, but the function actually returns avoid
because it lacks areturn
statement.This exception breaks our CI pipeline because it throws on both successful and unsuccessful runs of
commitAndPush
, and suppressing the error would end up hiding legitimate errors.