-
Notifications
You must be signed in to change notification settings - Fork 196
DEVX-3831: Create new Dockerfile to run Terminus in isolated environment #2735
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: 4.x
Are you sure you want to change the base?
DEVX-3831: Create new Dockerfile to run Terminus in isolated environment #2735
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
non-blocking comment. The Dockerfile part looks good to me.
build_docker_image: | ||
runs-on: ubuntu-latest | ||
name: Build Docker image | ||
steps: | ||
- name: Checkout | ||
uses: actions/checkout@v3 | ||
- name: Build Docker image | ||
run: docker build . -t terminus | ||
- name: Run built Docker image | ||
run: docker run terminus art | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Might be worth holding of on this until we have a public registry we can push to or until this repo has been onboarded to the WIF stuff so we can use the shared actions.
- Install base dependencies in Dockerfile - Add README instructions to utilize standalone Docker container method - Add notes on using Docker volume for config persistence
e22ed0d
to
ce4b1d4
Compare
For customers that do not (or prefer not) to have a local PHP environment like potentially Next.js developers, an alternative installation method via Docker avoids any need for local setup.
Specifically, the local flow is -
docker build . -t terminus docker volume create terminus --ignore docker run -tv terminus:/root/.terminus terminus:latest self:info
Presumably, the user flow would be -