Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Remove circular dependencies in headers #295

Merged
merged 2 commits into from
Feb 11, 2025

Conversation

navrocky
Copy link
Contributor

@navrocky navrocky commented Feb 9, 2025

This fix removes circular dependencies from specific headers node.hpp and function_storage.hpp to grouping header inja.hpp. This problem leads to high CPU load when parsing sources by clangd language server. Also, many errors are highlighted in the sources.

@navrocky navrocky changed the title Remove circular dependencies in headers Fix: Remove circular dependencies in headers Feb 9, 2025
@navrocky navrocky force-pushed the fix/circular-includes branch from fe5ae2a to 2163c0b Compare February 9, 2025 20:16
Copy link
Owner

@pantor pantor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thanks for the cleanup!

@pantor pantor merged commit 384a6be into pantor:main Feb 11, 2025
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants