improve tfsec version providing, behavior, add more known versions

[purajit]

• Most importantly, make the check_existence check search for all configs. Currently, it completely ignores _tfchecks.{yaml,json}, the standard way to define custom checks.
• Add v1.28.6 and make it the default
• I find it less hacky to provide version numbers as semver-like strings, and add "v"s and other prefixes where needed. (Versus substringing). I can undo if there are strong opinions here.

[lilatomic]

Thanks for this!

For context, the config file originally just pulled in the config file itself. But this is probably the easiest way to pull the custom tests in for execution.

Using plain semver strings makes sense to me, IDK why I did it like this originally.

I was going to ask you to add a custom check to the integration test. But it looks like it's not possible to change the ignored paths for the test runner. So, assuming you've tested this manually, nevermind.

[purajit]

Thanks for this!

For context, the config file originally just pulled in the config file itself. But this is probably the easiest way to pull the custom tests in for execution.

Using plain semver strings makes sense to me, IDK why I did it like this originally.

I was going to ask you to add a custom check to the integration test. But it looks like it's not possible to change the ignored paths for the test runner. So, assuming you've tested this manually, nevermind.

Yeah, I was debating whether to explicitly just add .tfsec/_tfchecks.{yaml,json} instead of using a glob, but I figured a glob would be better so that we don't have to constantly keep this up-to-date with any additional configs/name changes tfsec might do. And yes, tested manually!

[lilatomic]

I tested manually myself, looks good!
I've got an idea for modifying the rule runner to allow setting the ignore paths. I'm going to merge this and then see if I can get that to work and get a test in.

[lilatomic]

Test added in #21116 . Turns out it was easier than I thought; bootstrap_args already does all the plumbing necessary.

[sureshjoshi]

@lilatomic @purajit

Is this a breaking change for people who specified the tool version in their pants.toml?