Update yaml globs for Helm to support common chart structures#21692
Update yaml globs for Helm to support common chart structures#21692cburroughs merged 6 commits intopantsbuild:mainfrom
Conversation
|
Thanks for the fix! Can you please also add an entry to the changelog in "docs/notes/2.25.x.md" under the Helm section? I've also marked this MR for packporting |
lilatomic
left a comment
There was a problem hiding this comment.
Tested and looks good!
|
I'm going to go ahead and add a brief doc note. Thank you for your contribution! |
|
I tried to automatically cherry-pick this change back to each relevant milestone, so that it is available in those older releases of Pants. ✔️ 2.23.xSuccessfully opened #21897. ✔️ 2.24.xSuccessfully opened #21896. ❌ 2.25.xI was unable to cherry-pick this PR to 2.25.x, likely due to merge-conflicts. Steps to Cherry-Pick locallyTo resolve:
Please note that I cannot re-run CI if a job fails. Please work with your PR approver(s) to re-run CI if necessary. When you're done manually cherry-picking, please remove the Thanks again for your contributions! |
|
Whoops, didn't mean to cheery pick |
Minor fix, but this bit my colleague the other day and had him pretty confused as to why his chart was broken, so I thought I'd fix it upstream.