fix: thread agent command through model discovery endpoint

[mjaverto]

Summary

• The GET /adapters/opencode_local/models endpoint called listOpenCodeModels() with no arguments, always falling back to the default opencode command. When the default binary was unavailable (e.g. stale nix store path), it returned [] even though agents had a working custom command in their adapterConfig.
• The route now accepts an optional agentId query param, looks up the agent's persisted adapterConfig.command, and passes it through — never exposing raw user input to process execution.
• Added test for the command option passthrough.

Test plan

• pnpm tsc --noEmit passes
• pnpm vitest run packages/adapters/opencode-local/src/server/models.test.ts — 4/4 pass
• Manual: configure an agent with a custom command in adapterConfig, hit GET /adapters/opencode_local/models?agentId=<id>, verify models populate

Fixes #1904

🤖 Generated with Claude Code

[greptile-apps]

Greptile Summary

This PR threads an agent's persisted adapterConfig.command through the GET /adapters/:type/models route so that agents using a non-default opencode binary get their models populated correctly. The approach — accepting an agentId query param, looking it up in the DB, and extracting the stored command rather than accepting raw user input — is the right design. The plumbing in models.ts, registry.ts, and types.ts is clean and correct.\n\nHowever, the route handler contains a critical bug that renders the entire feature non-functional:\n\n- svc.getById(companyId, agentId) passes the wrong argument. The service's getById(id: string) accepts exactly one parameter. JavaScript silently discards the second argument, so companyId is used as the agent ID in the DB query. The query will never match an agent, command will always be undefined, and the default opencode binary continues to be used — exactly the problem the PR intends to fix.\n- The call should be svc.getById(agentId) with a subsequent agent.companyId === companyId guard (to prevent cross-company command extraction).\n- The PR description is missing the "Thinking Path" format required by CONTRIBUTING.md — please add a brief top-down narrative explaining the problem and the fix.

Confidence Score: 4/5

Not safe to merge as-is — the core feature silently does nothing due to the wrong argument being passed to getById.

One P1 defect: svc.getById(companyId, agentId) passes companyId as the id, agentId is ignored, agent lookup always returns null, command is never extracted. The fix is a one-line change. All other parts of the PR (types, registry, models, test) are correct.

server/src/routes/agents.ts — the getById call on line 673 must be corrected before merging.

Important Files Changed

Filename	Overview
server/src/routes/agents.ts	Route now reads agentId from query param and looks up adapterConfig.command, but calls svc.getById(companyId, agentId) — passing companyId as the id argument and silently discarding agentId, so the agent is never found and the command is never passed through.
packages/adapters/opencode-local/src/server/models.ts	listOpenCodeModels now accepts optional { command? } and forwards it to discoverOpenCodeModelsCached — straightforward and correct.
packages/adapters/opencode-local/src/server/models.test.ts	Adds test covering the new command option path; verifies graceful fallback with an invalid binary, which is the expected behavior.
server/src/adapters/registry.ts	listAdapterModels now accepts optional opts and forwards them to adapter.listModels — clean and backward-compatible.
packages/adapter-utils/src/types.ts	listModels signature updated to accept optional opts; change is backward-compatible since opts is optional.

Prompt To Fix All With AI

This is a comment left during a code review.
Path: server/src/routes/agents.ts
Line: 673-676

Comment:
**Wrong argument passed to `getById` — feature is silently non-functional**

`svc.getById` (defined in `server/src/services/agents.ts` line 241) accepts exactly **one** parameter, `id: string`. Calling it as `svc.getById(companyId, agentId)` passes `companyId` as the `id` argument; JavaScript silently ignores the second argument `agentId`. As a result the DB query runs `WHERE agents.id = <companyId>`, which will never match an agent row. `agent` comes back `null`, `command` is never assigned, and the entire command-passthrough feature silently no-ops — the bug this PR aims to fix is still present.

All other call sites in `agents.ts` pass a single ID: `svc.getById(req.actor.agentId)`, `svc.getById(id)`, etc.

The call should be `svc.getById(agentId)` with an explicit company-ownership guard to prevent cross-company data leakage:

```suggestion
      const agent = await svc.getById(agentId);
      if (agent && agent.companyId === companyId && agent.adapterConfig && typeof agent.adapterConfig.command === "string") {
        command = agent.adapterConfig.command;
      }
```

How can I resolve this? If you propose a fix, please make it concise.

_{Reviews (1): Last reviewed commit: "fix: thread command option through listA..." | Re-trigger Greptile}

[mjaverto]

Addressed in f41a8d3: Fixed svc.getById(companyId, agentId) → svc.getById(agentId) with explicit agent.companyId === companyId guard. The inline thread is resolved.

Re: CONTRIBUTING.md Thinking Path format — will add if required by maintainers, but keeping the PR description focused on the technical fix for now.

[mjaverto]

Closing in favor of a new PR with the correct approach — passing command directly from the UI form instead of looking up by agentId.