-
Notifications
You must be signed in to change notification settings - Fork 520
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added number badge on top the tab icon to show the number of active conversations #421
base: master
Are you sure you want to change the base?
Conversation
- fixes to render correctly in firefox - correct size - the icon is aligned to a 2x2 grid to render crisp on retina - has update colours that work on light and dark mode Added: Show number of active conversations on top of the badge icon
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hey @arjenrschat! thanks for sharing this, we'll definitely play around with it and see if it looks good to merge :)
a couple things:
- was most of the code copy/pasted from somewhere? if so, can you share the link?
- how many numbers does this support? i.e. if there are 99 messages, will it show "99" in the icon badge?
- is there a way we can make the number fit in the red circle more nicely?
got it! maybe we can start off simple with something like Slack, and just show a red dot when there are unread messages... I think that will look nicer for the time being |
The number is removed from the badge |
thanks @arjenrschat -- can you share a screenshot of how the latest code looks in both light and dark mode? |
Added data-react-helmet property to the link, this forces Helmet to override the existing icon Removed Canvas rendering Added logo with unread badge
Description
Improved logo.svg
- fixes to render correctly in firefox
- correct size
- the icon is aligned to a 2x2 grid to render crisp on retina
- has update colours that work on light and dark mode
Added: Show number of active conversations on top of the badge icon
Screenshots