Merge pull request #249 from leonk/master-fix-comments-with-numbers

Fixes #247 numbers in comments can cause php fatal errors.
paquettg · Nov 1, 2020 · 79730ce · 79730ce
2 parents f5c2dd9 + 5572180
commit 79730ce
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/PHPHtmlParser/Dom/Tag.php b/src/PHPHtmlParser/Dom/Tag.php
@@ -329,6 +329,8 @@ public function makeOpeningTag()
             } catch (AttributeNotFoundException $e) {
                 // attribute that was in the array not found in the array... let's continue.
                 continue;
+            } catch (\TypeError $e) {
+              $val = null;
             }
             $val = $attributeDTO->getValue();
             if (\is_null($val)) {

diff --git a/tests/Node/TextTest.php b/tests/Node/TextTest.php
@@ -4,6 +4,7 @@
 
 use PHPHtmlParser\Dom;
 use PHPHtmlParser\Dom\Node\TextNode;
+use PHPHtmlParser\Options;
 use PHPUnit\Framework\TestCase;
 use stringEncode\Encode;
 
@@ -74,4 +75,14 @@ public function testSetTextEncoded()
         $node->setText('biz baz');
         $this->assertEquals('biz baz', $node->text());
     }
+
+    public function testCommentWithNumbers() {
+      $dom = new Dom;
+      $options = new Options();
+      $options->setCleanupInput(false);
+      $dom->setOptions($options);
+      $dom->loadStr('<!-- test comment with number 2 -->');
+      $output = $dom->outerHtml;
+      $this->assertContains('<!-- test comment with number 2 -->', $output);
+    }
 }