-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add windows Ipc Client implementation #7187
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 3 commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
f6113e8
Add windows Ipc Client implementation
AbnerZheng 67a08fe
Merge branch 'paradigmxyz:main' into issue-6526
AbnerZheng cf2a2d6
clippy
AbnerZheng ab46935
enable test in windows
AbnerZheng da75264
refactor
AbnerZheng 6f2e639
clippy
AbnerZheng 8a3192e
wip
AbnerZheng 5432082
merge from main
AbnerZheng 6fb614d
transition to interprocess
AbnerZheng 2cc6257
fix test
AbnerZheng 6939aea
Merge branch 'main' into issue-6526
AbnerZheng be008d9
use interprocess 1.2.1 and remove FutureDriver
AbnerZheng e672755
fix lint
AbnerZheng d54da13
allow CC0-1.0 license
AbnerZheng d1d2e80
apply suggestions from review
AbnerZheng c00bea4
apply suggestions from review
AbnerZheng 968349f
fix lint
AbnerZheng 5fccb86
fix lint
AbnerZheng 28d88e9
fix cargo doc check
AbnerZheng 1bd9884
apply suggestions from review
AbnerZheng c7f8bfb
apply suggestions from review
AbnerZheng 67090da
apply suggestions from review
AbnerZheng 921f39b
reformat
AbnerZheng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is great,
what I would like to do instead is:
convert client into a module with
unix.rs
win.rs
and duplicate the types then client/mod.rs reexports based on windows or UNIX
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done.