Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This implementation refers to issue #158. Implementation-wise, it follows the same ideas as
p_fir
(see PR #152 for details). Notes:p_firsym
implements symmetric FIR filters of odd length (a.k.a., type I). In other words, filters such as1, 2, 3, 4, 5, 4, 3, 2, 1
. In this case, one would passh = {1, 2, 3, 4, 5}
andnh = 5
to the function.1 2 3 4 4 3 2 1
) cannot be high pass or band stop. Type I filters have no restrictions.p_firsym
is generally faster thanp_fir
. On ARM cores, it is always faster. On Intel i7, it is only slightly slower for shorter filters (smallnh
). The result of a larger benchmark can be found in dsp: p_firsym: API issue and implementation #158.I'll push the tests for this function and
p_fir
ASAP.--Chamon ([email protected])