math:tan: Generate unit testing data on [0, 2pi] #190
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed the unit testing data (gold) for the tangent function seems to be bound to [-1, 1] but it should be bound to [0, 2pi]. (This was mentioned in #166.) So I generated new data.
Ironically, my tangent implementation had a couple bugs, but produced good results with the bad data...
I generated the new data in Python:
I removed two lines for input close to a multiple of pi/2 since they produce garbage (+/- infinity).
This new data helped me fix two bugs.