Update p_box3x3.c #76
Conversation
Fix stopping conditions of previous edit. Simplified stopping conditions.
Computing address of a pointer outside array bounds is undefined, so don't increment *px in the last cell. Also it's unnecessary.
input image: output image |1 1 1 1| |0 0 0 0| |1 1 1 1| |0 1 1 0| |1 1 1 1| |0 1 1 0| |1 1 1 1| |0 0 0 0| Note that here we do not assign 0 to the outside cells in the output image.
|
Looks right to me. One remaining question mark for me is how the algo should behave around the edges. Take the upper leftmost pixel @ (x,y)=(0,0) for example. Shouldn't we apply the filter there too, but only for its neighboring pixels that are actually in the image? ping @aolofsson |
|
The most basic image filter will simply disregard the edges rather than performing some alternate calculations, as is done here. Note that input dimension: rows x cols. Output image dimension: (rows - 2) x (cols - 2). If you want to apply the filter in the corners, there are many options but almost all would require different output image dimensions than current. Common ones treat all outside pixels as zero, the same as the nearest pixel, or as an average of nearby pixels. Some discussion here: #106 |
|
Very old merge request. |
Fix stopping conditions of previous edit. Simplified stopping conditions.