Skip to content

Package.py'de bare except kullanımları düzeltildi #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cyphermen wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Package.py'de bare except kullanımları düzeltildi #20

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions src/Package.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,8 @@ def updatecache(self):
try:
self.cache = apt.Cache()
self.cache.open()
except:
except (SystemError, Exception) as e:
print("Failed to update cache: {}".format(e))
return False
if self.cache.broken_count > 0:
return False
Expand All @@ -50,14 +51,14 @@ def control_dpkg_interrupt(self):
def controlPackageCache(self, packagename):
try:
self.cache[packagename]
except:
except KeyError:
return False
return True

def isinstalled(self, packagename):
try:
package = self.cache[packagename]
except:
except KeyError:
return None
return package.is_installed

Expand Down Expand Up @@ -202,11 +203,11 @@ def candidate_version(self, packagename):
def installed_version(self, packagename):
try:
package = self.cache[packagename]
except:
except KeyError:
return None
try:
version = package.installed.version
except:
except AttributeError:
version = ""
return version

Expand Down Expand Up @@ -323,7 +324,8 @@ def required_changes_upgrade(self, sleep=True, keep_list=None):
self.cache[kd].mark_keep()
user_keep_list_depends.append(kd)
print("keeping from depends: {}".format(kd))
except:
except (KeyError, SystemError) as e:
print("Could not process dependency {}: {}".format(kd, e))
continue
except Exception as e:
print("{} not found".format(kp))
Expand Down