Repository navigation
fix(ci): the certificate renewal keeps its SSH connection alive and logs certbot's steps - #372
Merged
Merged
Conversation
…ogs certbot's steps
Contributor
Bundle Size ReportEager path (module entry + modulepreloaded chunks):
Chunks over 500 KB:
All files
Commit: 9c3b34d |
Contributor
⚡ Performance ReportCold StartOverall: 🟢 improved | p50: 10.72s → 8.73s (-18.6%) | p95: 11.79s → 9.55s (-19.0%) | Mann-Whitney: z=4.40 ✅ significant Phase breakdown
Warm StartOverall: 🔴 regressed | p50: 424ms → 539ms (+27.1%) | p95: 451ms → 579ms (+28.4%) | Mann-Whitney: z=4.41 ✅ significant Phase breakdown
Lukewarm Start (different site, same session)Overall: 🟢 improved | p50: 13.82s → 10.99s (-20.5%) | p95: 14.69s → 12.76s (-13.1%) | Mann-Whitney: z=4.40 ✅ significant Phase breakdown
Commit: 9c3b34d | Outliers (>2x best) discarded before stats |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The first Renew certificate run for paseo.li failed with
Broken pipe. certbot printed nothing for about 4.5 minutes, and the runner's idle timeout cut the SSH connection before certbot finished.The SSH call now sends keepalives, certbot runs with
-vso the log shows which step it is waiting on, and the job times out after 15 minutes.make -n renew-cert ENV=<tag>renders the expected remote command.