Repository navigation
fix(host): a subname opens by its path on the bare host - #394
Merged
Merged
Conversation
Contributor
Bundle Size ReportEager path (module entry + modulepreloaded chunks):
Chunks over 500 KB:
All files
Commit: 31753c0 |
Contributor
⚡ Performance ReportCold StartOverall: 🟢 improved | p50: 11.21s to 10.26s (-8.4%) | p95: 12.44s to 11.48s (-7.7%) | Mann-Whitney: z=3.61 ✅ significant Phase breakdown
Warm StartOverall: 🔴 regressed | p50: 367ms to 432ms (+17.7%) | p95: 411ms to 477ms (+16.1%) | Mann-Whitney: z=4.40 ✅ significant Phase breakdown
Lukewarm Start (different site, same session)Overall: 🟢 improved | p50: 14.14s to 12.52s (-11.5%) | p95: 15.04s to 13.89s (-7.7%) | Mann-Whitney: z=3.92 ✅ significant Phase breakdown
Commit: 31753c0 | Outliers (>2x best) discarded before stats |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
paseo.li/pr16.back-me-upfell through to the landing page. nginx served the shell, but the path route accepted a single dotNS label only, so a subname was refused. Its sandbox origin would also have beenpr16.back-me-up.app.paseo.li, which the*.app.<domain>wildcard certificate does not cover.The path route now accepts a subname, with each label checked. A subname's sandbox origin is one DNS label,
sn--plus a sha256 of the name, so the existing certificate covers it. A single label keeps its origin and storage. No registered label may start withsn--, so none can take a subname's origin.