Merged
Conversation
2 tasks
seunlanlege
approved these changes
Jun 30, 2021
Contributor
|
just needs to fix CI build errors |
niklasad1
reviewed
Jun 30, 2021
niklasad1
approved these changes
Jun 30, 2021
Contributor
niklasad1
left a comment
niklasad1
left a comment
There was a problem hiding this comment.
LGTM, one question about the server feature for the http client
Contributor
Author
|
Added some more commits since the last review. Can I get a final rubber-stamp before merging this? |
tomusdrw
approved these changes
Jul 6, 2021
Xanewok
commented
Jul 7, 2021
| Poll::Pending => return Poll::Pending, | ||
| Poll::Ready(()) => {} | ||
| Poll::Ready(()) => { | ||
| self.suspended_until = None; |
Contributor
Author
There was a problem hiding this comment.
If we're ready then let's reset the suspension flag not to execute that code path everytime
Contributor
Author
|
Thanks for the reviews! Would it be possible to release new versions of the crates somewhat soon that contain this PR? |
Contributor
I guess we should bump the version first. I guess 18.x ? |
Contributor
Author
|
Yep, sounds good. I'll prepare a bump PR if that's okay |
Merged
bors
added a commit
to rust-lang/rls
that referenced
this pull request
Aug 24, 2021
Bump to Tokio 1.0 Closes #1695 Closes #1693 Just enabled by tokio-rs/tokio#3388. Work in progress to prune winapi 0.2, still needs patches upstreamed that migrate `parity-tokio-ipc` and `jsonrpc-*` crates to Tokio 1.0. Let's see what CI has to say, first. Blocked on: - [x] paritytech/parity-tokio-ipc#32 - [x] paritytech/jsonrpc#628
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs paritytech/parity-tokio-ipc#32 (pulls a[patch.crates-io]in the meantime).Closes #621
Primary motivation is to fix RLS build on aarch64 Windows (see rust-lang/rls#1741). Tested locally on a Windows machine, hopefully unix will be happy as well.
https://tokio.rs/blog/2020-10-tokio-0-3 might be useful when reviewing