Repository navigation
Conversation
This was referenced Oct 16, 2026
Collaborator
|
Should we close this in favour of #1662? |
Contributor
Author
|
yes, we can close this one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1660.
Validate JSON syntax before extracting the request ID, so valid JSON with an invalid request envelope returns InvalidRequest. Add helper and HTTP/WebSocket regressions and correct existing expectations.
Validation: baseline regression fails before the fix; 16 core and 20 distinct server tests pass in release, offline. Formatting and targeted all-features/all-targets Clippy pass; Clippy reports an existing unused lifetime in server.rs.