replace duplicate code with common function #394
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
reviewed
Jun 4, 2025
src/protocol/mod.rs
Outdated
| @@ -141,3 +142,18 @@ pub trait UserProtocol: Send { | |||
| /// Start the the user protocol event loop. | |||
| async fn run(self: Box<Self>, service: TransportService) -> crate::Result<()>; | |||
| } | |||
|
|
|||
| pub fn sort_address(addresses: impl Iterator<Item = Multiaddr>, peer_id: PeerId) -> Vec<Multiaddr> { | |||
There was a problem hiding this comment.
nit: I would name this method ensure_address_with_peer or similar, since it is not really sorting the input 👍
There was a problem hiding this comment.
Yeah, that's a better name. Would use that instead
lexnv
reviewed
Jun 4, 2025
| @@ -188,17 +190,7 @@ impl RoutingTable { | |||
| ); | |||
|
|
|||
| // TODO: https://github.com/paritytech/litep2p/issues/337 this has to be moved elsewhere at some point | |||
There was a problem hiding this comment.
We could probably remove the TODO here? Or do you think there are more places where this may happen? 🤔
There was a problem hiding this comment.
Oh yeah, I forgot to remove that. It's all covered now, no more duplicates
lexnv
reviewed
Jun 19, 2025
src/protocol/transport_service.rs
Outdated
| } | ||
| }) | ||
| .collect(); | ||
| let addresses = ensure_address_with_peer(addresses.into_iter(), *peer); |
There was a problem hiding this comment.
There's one tiny issue with this approach: we were previously collecting into a HashSet, which deduplicates items. Whereas using the Vec by default, we could have duplicates here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Aims to resolve #337
Also fixes clippy warning issues