kademlia: Track success of ADD_PROVIDER queries
#432
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
lexnv
reviewed
Sep 17, 2025
| @@ -1,5 +1,3 @@ | |||
| // Copyright 2023 litep2p developers | |||
There was a problem hiding this comment.
nit: Should we do the same for all other files and just keep the copyright without the year?
There was a problem hiding this comment.
Actually, accidentally deleted these lines. Will revert.
Yes, we can live without a year as in polkadot-sdk.
lexnv
reviewed
Sep 17, 2025
|
|
||
| /// Kademlia message. | ||
| #[derive(Debug, Clone)] | ||
| #[derive(Debug, Clone, EnumDisplay)] |
There was a problem hiding this comment.
dq: This is used to display the message in the logs?
lexnv
reviewed
Sep 22, 2025
| context.register_response_failure(peer); | ||
| } | ||
| Some(QueryType::PutRecordToFoundNodes { context, .. }) => { | ||
| Some(QueryType::PutRecordToFoundNodes { context }) => { |
There was a problem hiding this comment.
nit: Maybe we can introduce a fn context() on the QueryType, such that we can turn this code into:
match self.queries.get_mut(&query) {
None => ...,
Some(query) => query.context.register_response_failure(peer);
}
lexnv
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Track success of
ADD_PROVIDERqueries and emitAddProviderSuccess&QueryFailedevents.This PR adds tracking of the last stage of
ADD_PROVIDERquery: putting provider records to the target peers. Because libp2p spec doesn't haveADD_PROVIDERACK messages, we track only that the requests were sent out to the target peers without errors.Quorumis respected when determining whether the query was successful or not.Builds upon #430.