improve efficiency of propagating address failures #443
+43
−17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lexnv
reviewed
Oct 10, 2025
lexnv
reviewed
Oct 10, 2025
lexnv
reviewed
Oct 16, 2025
lexnv
reviewed
Oct 16, 2025
lexnv
reviewed
Oct 16, 2025
src/transport/manager/mod.rs
Outdated
Comment on lines
1138
to
1140
| let adresses = context.dial_failure_addresses(&[address.clone()]); | ||
|
|
||
| match context.tx.try_send(make_dial_failure_event(peer, adresses.clone())) { |
There was a problem hiding this comment.
nit: Is there a way to avoid the cloning here? Maybe changing the signature of the fn to take a & Multiaddr?
I would also inline the make_dial_failure_event:
match context.tx.try_send(InnerTransportEvent::DialFailure { peer, addresses })Instead of cloning the addreses here (addresses.clone()), we could recreate the addresses on error
There was a problem hiding this comment.
i have changed to this inline way, but can't still do without cloning
lexnv
approved these changes
Oct 31, 2025
dmitry-markin
approved these changes
Nov 3, 2025
| peer, | ||
| addresses: vec![address.clone()], | ||
| }) | ||
| .send(InnerTransportEvent::DialFailure { peer, addresses }) |
There was a problem hiding this comment.
@dharjeezy Can you also add to the doc of InnerTransportEvent & TransportEvent that addresses is only forwarded if the protocol was registered with DialFailureAddresses::Required, please?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #409