Skip to content

Conversation

@iTranscend
Copy link
Contributor

This PR provides a fix for the strange order identified in #455 and updates the transport_events test to validate the new behaviour.

As explained in #455, polling order is now sanitized and resumes wherever it left off in a previous call to poll_next.

resolves #455

Copy link
Collaborator

@dmitry-markin dmitry-markin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The issue and PR make sense. The original implementation tried to overcome the biased nature of naive polling in a loop, but the new round-robin implementation is even nicer.

Thanks for handling this!

@iTranscend
Copy link
Contributor Author

this was one of them "i saw and had to scratch that itch" fixes 😄

glad it was helpful 🙂

Copy link
Collaborator

@lexnv lexnv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! Looks good! Thanks for contributing 🙏

@lexnv lexnv merged commit 1e3fa87 into paritytech:master Nov 4, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Odd TransportContext polling behavior

3 participants