Snowbridge V1: deprecate fee handler#8239
Closed
yrong wants to merge 1 commit intoparitytech:masterfrom
Closed
Conversation
2 tasks
yrong
force-pushed
the
deprecate-fee-handler
branch
from
b4eb0db to
fa2dc86
Compare
Contributor
Author
|
Closed in favor of yrong#20 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
To simplifies the fee flow in V1 to mimic that of V2 and removes deprecated codes.
It also makes setting BridgeHubEthereumBaseFee on AH easier - we can set it to a very low value (to encourage end users to use the bridge) without worrying about matching the execution cost on Ethereum.