added trace logging in EVM interpreter loop #9561
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cmd prdoc --audience runtime_dev --bump patch |
|
/cmd bench --runtime dev --pallet pallet_revive |
|
Command "bench --runtime dev --pallet pallet_revive" has started 🚀 See logs here |
…--pallet pallet_revive'
|
Command "bench --runtime dev --pallet pallet_revive" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
xermicus
approved these changes
Aug 27, 2025
pgherveou
reviewed
Aug 28, 2025
|
We need the run_plain function in #9414 in order to propagate the Edit: Maybe not and we can get around with error conversions. Ignore this comment for now. |
smiasojed
reviewed
Aug 28, 2025
substrate/frame/revive/src/vm/evm.rs
Outdated
| interpreter.bytecode.pc(), | ||
| OpCode::new(interpreter.bytecode.opcode()) | ||
| .map_or("INVALID".to_string(), |x| format!("{:?}", x.info())), | ||
| interpreter.stack.top().map_or("None".to_string(), |x| format!("{:#x}", x)), |
There was a problem hiding this comment.
Thanks, looks good. Is there a way to print more than just the top of the stack? Many functions pop more than one argument. 5 values would be a good limit I think
There was a problem hiding this comment.
Not without popping elements, then printing, and then pushing them back.
added 2 commits
August 28, 2025 16:56
|
Review required! Latest push from author must always be reviewed |
pgherveou
approved these changes
Aug 28, 2025
xermicus
approved these changes
Aug 29, 2025
added 7 commits
August 29, 2025 13:02
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
|
Why so many conditionals? You can just define the function twice. Once for std and once without. You can also move the action inside. Where the no-std version just calls the original |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added trace logging for each instruction to evm::run function.
solves #9575