[unstable2507] Backport #9319 #9899
Open
+307
−137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…metrics accuracy (#9319) # Description The polkadot_parachain_collation_expired metric is an indicator for parachain block confidence. However, this metric has a critical issue: not every drop should be counted. Lookahead collators intentionally build collations on a relay chain block and its forks, so the drop of fork-based collations is an expected behaviour. If we count them, the drop metrics show a picture that is worse than in reality. To improve tracking accuracy, we should exclude legit drops The minor issue is also present in the expiry mechanism. It doesn't take into account that collation was moved to a different stage, e.g., from "fetched" to "backed", and can write a drop of fetched collation. To solve this issue we should: - Track relay parent finalization. - Record expiration metrics only when relay parent was finalized. - Exclude drops of fork-based collation from the metrics. - Send metrics only for collations that either finalized or dropped. --------- Co-authored-by: cmd[bot] <41898282+github-actions[bot]@users.noreply.github.com> (cherry picked from commit d51c532)
github-actions
bot
added
the
A3-backport
AndreiEres
approved these changes
Oct 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #9319 into
unstable2507from AndreiEres.See the documentation on how to use this bot.