pallet-revive: add mechanism to manipulate caller and delegate_calls #9909
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alexandru Gheorghe <[email protected]>
alexggh
requested review from
pgherveou,
athei,
pkhry,
smiasojed and
filip-parity
athei
reviewed
Oct 2, 2025
Comment on lines
+112
to
+118
| pub struct InjectExecEnv<T: frame_system::Config> { | ||
| pub caller: OriginFor<T>, | ||
| pub delegated_caller: Option<OriginFor<T>>, | ||
| pub callee: H160, | ||
|
|
||
| pub first_call_only: bool, | ||
| } |
There was a problem hiding this comment.
Please don't add top level items. It is cluttered enough already. Should go into a separate cheat_code module where we bundle all the things just needed for cheat codes.
| gas_limit, | ||
| DepositLimit::Balance(storage_deposit_limit), | ||
| data, | ||
| None, |
There was a problem hiding this comment.
Adding new arguments here is really annoying. This is why I added a more general ExecConfig here: #9803
Let's wait for this PR and then you can include your structure into ExecConfig.
There was a problem hiding this comment.
Nice I think I can work with that, I have the luxury of being able to point foundry at a branch, so I will work on adapting this PR on top of yours.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Needed for: paritytech/foundry-polkadot#334.
In foundry-polkadot we need the ability to be able to manipulate the
msg.senderand thetx.originthat a solidity contract sees cheatcode documentation.Currently all create/call methods use the
bare_instantiate/bare_callto run things in pallet-revive, the caller then normally gets set automatically, based on what is the call stack, but forforge testwe need to be able to manipulate, so that we can set it to custom values.Additionally, for delegate_call, bare_call is used, so there is no way to specify we are dealing with a delegate call, so the call is not working correcly.
For both this paths, we need a way to inject this information into the execution environment, hence I added an optional structure that we can populate from foundry. I'm open to other better ideas.