Fix statement-store gossiping #9912
Open
+189
−11
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndreiEres
force-pushed
the
AndreiEres/fix-statement-store-gossiping
branch
from
860f41c to
7b8aeb1
Compare
|
/cmd prdoc --audience node_dev --bump patch |
…e_dev --bump patch'
AndreiEres
changed the title
bkchr
reviewed
Oct 2, 2025
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
bkchr
reviewed
Oct 3, 2025
|
|
||
| // Size exceeded - split the chunk | ||
| let split_factor = | ||
| (encoded.len() / MAX_STATEMENT_NOTIFICATION_SIZE as usize) + 1; |
There was a problem hiding this comment.
Suggested change
| (encoded.len() / MAX_STATEMENT_NOTIFICATION_SIZE as usize) + 1; | |
| (encode_size / MAX_STATEMENT_NOTIFICATION_SIZE as usize) + 1; |
| if new_chunk_size == 0 { | ||
| log::warn!( | ||
| target: LOG_TARGET, | ||
| "Statement too large ({} KB), skipping", |
There was a problem hiding this comment.
It would be nice to exactly skip the one statement that is problematic and not maybe more.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes gossiping and scalability issues in the statement-store networking.
Integration
Internal optimizations to the gossip protocol. No downstream changes required.