[wip] Fix PoV size reclaim #9924
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a first step into fixing #6020. The underlying problem for parachains is that when calling `storage_root`, values that are written, will need to be looked up in the trie. This is required to insert the value or to remove it. The problem is that this lookup in `storage_root` increases the storage proof size, but storage reclaim for example can not track these lookups. This means that with storage reclaim it is possible to include more transactions than what the block should be allowed to include. This pull request reads a key from the backend the first time it is written. This results in taking into account what `storage_root` is doing at the end of a block. However, this may still skips reading one extra `node` (depending on the trie structure). Skipping only one `node` is far less problematic than skipping the entire lookup. A future pull request will improve this further to take the entire operation of `storage_root` into account. For chains that are not recording a storage proof, they will still do this extra backend read. However, this read will end up in the cache. At the end of the block the key will be read again as part of `storage_root`, but served from the cache. So, there is no downside of this.
This reverts commit 4f00caf.
|
/cmd bench --help |
Command help: |
|
/cmd bench --runtime asset-hub-westend |
|
Command "bench --runtime asset-hub-westend" has started 🚀 See logs here |
|
Command "bench --runtime asset-hub-westend" has failed ❌! See logs here |
|
/cmd bench --runtime asset-hub-westend |
|
Command "bench --runtime asset-hub-westend" has started 🚀 See logs here |
|
Command "bench --runtime asset-hub-westend" has failed ❌! See logs here |
|
/cmd bench --runtime asset-hub-westend |
|
Command "bench --runtime asset-hub-westend" has started 🚀 See logs here |
|
Command "bench --runtime asset-hub-westend" has finished ✅ See logs here Subweight results:
Command output:✅ Successful benchmarks of runtimes/pallets: |
|
All GitHub workflows were cancelled due to failure one of the required jobs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.