Staking-Async Chill stakers should not have a score #9926
+72
−3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That can re-instate them in the bags-list pallet
Identified by https://github.com/paritytech-secops/srlabs_findings/issues/559
While no severe consequence, this bug could cause non-validator and non-nominator stakers to retain a spot in the bags-list pallet, preventing other legit nominators/validators from taking their place.
Note that previously, this was not a possibility, because
staking
would always issue aT::VoterList::on_remove
when someonechill
s, ensuring they are removed from the list. Moreover, an older version ofpallet_bags_list::Pallet::rebag
didn't allow new nodes to be added, only the score of existing nodes to be adjusted.But, in recent versions of
bags-list
, we added aLock
ability that would block any changes to the bags list (during the election snapshot phase). This also had us update therebag
transaction to add or remove nodes from the list, which opened the door to this issue.