Skip to content

[WIP] Cumulus: pre-connect to backers before own slot #9929

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 12 commits into
base: alexggh/cleanup_connecting_to_backing_group
Choose a base branch
from
Open

[WIP] Cumulus: pre-connect to backers before own slot #9929

wants to merge 12 commits into from

Conversation

sandreim
Copy link
Contributor

@sandreim sandreim commented Oct 3, 2025 •
edited
Loading

On top of #9178. Implements a mechanism to pre-connect to backers, see #9767 (comment)

TODO:

  • fix collator protocol tests
  • improve logic to handle 24s slots, we'd want to start connecting later than the begging of the prev author slot.
  • add test coverage for new connect/disconnect notifications

@sandreim
Support ConnectToBackingGroups
39fb8e1 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
fix origin
47923b6 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
add disconnect mechanism
0ede4bb 
Signed-off-by: Andrei Sandu <[email protected]>
bkchr
bkchr reviewed Oct 3, 2025
View reviewed changes
@sandreim sandreim marked this pull request as ready for review October 4, 2025 09:20
@sandreim
move collator_protocol_helper
eb51a3e 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
comment
17d1c6c 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
remove helper from service
06c444f 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
unused
8fe9db5 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
unused deps in crates
3b63265 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Copy link
Contributor Author

sandreim commented Oct 4, 2025

/cmd prdoc generate --bump major

@sandreim sandreim added T0-node This PR/Issue is related to the topic “node”. T9-cumulus This PR/Issue is related to cumulus. labels Oct 4, 2025
github-actions bot and others added 3 commits October 4, 2025 10:25
@github-actions
Update from github-actions[bot] running command 'prdoc generate --bum…
bda8c38 
…p major'
@sandreim
fix tests
9cfd857 
Signed-off-by: Andrei Sandu <[email protected]>
@sandreim
Merge branch 'sandreim/collator_protocol_notifications' of github.com…
e954ea4 
…:paritytech/polkadot-sdk into sandreim/collator_protocol_notifications
@paritytech-workflow-stopper
Copy link

All GitHub workflows were cancelled due to failure one of the required jobs.
Failed workflow url: https://github.com/paritytech/polkadot-sdk/actions/runs/18244486870
Failed job name: fmt

@sandreim
Copy link
Contributor Author

sandreim commented Oct 4, 2025

/cmd fmt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bkchr bkchr bkchr left review comments

Assignees
No one assigned
Labels
T0-node This PR/Issue is related to the topic “node”. T9-cumulus This PR/Issue is related to cumulus.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sandreim @bkchr