interpreter: Do not emit two handlers for load_imm_and_jump #323
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We don't have to. :P This should work the same as it did before, i.e. only resolve the jump once when it first executes, instead of doing it each time. |
aman4150
force-pushed
the
load_imm_and_jump_opt
branch
from
51b9a4e to
8084f10
Compare
koute
reviewed
Aug 21, 2025
aman4150
force-pushed
the
load_imm_and_jump_opt
branch
from
8084f10 to
0b73a47
Compare
koute
approved these changes
Aug 26, 2025
|
LGTM |
Instead we emit a single handler that does both loading the immediate and jumping to the target. Signed-off-by: Aman <[email protected]>
aman4150
force-pushed
the
load_imm_and_jump_opt
branch
from
0b73a47 to
8d463f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead we emit a single handler that does both loading the immediate and jumping to the target.
Note, it does makes this expensive, because now we have to resolve the jump every time. But this is inline to what we have for
load_imm_and_jump_indirect.Fixes: #318