Skip to content

Conversation

athei
Copy link
Member

@athei athei commented Feb 28, 2025

This PR changes the CI build scripts to also build LLVM for windows. It doesn't build revive itself for windows. This will come in a follow up. But once we have a LLVM binary release the turn around time will be much quicker for experimenting with the revive windows build.

I manually uploaded the release those changes produce here. This enables this PR's CI to find the proper release. This is necessary because I am also making changes to the folder structure and artifact naming that the other CI jobs are depending on.

Releases generated from this branch can be inspected here: https://github.com/paritytech/revive-alex-workflowtest/releases/tag/v0.1.0-dev.12

Summary of changes:

  • Change llvm-builder to use MSVC toolchain on windows
  • Fix llvm-builder to work with .exe files
  • Unify the llvm release jobs into a single one. This removed a lot of copy pasted code and also speeds up the build by giving each their own runner.
  • Use the LLVM target triple to name the binary releases instead of an ad-hoc naming convention
  • Remove the nested folder hierarchy inside the llvm release. Its just now a single folder llvm-<target> that contains the toolchain.
  • Give jobs and workflows consistent names
  • Replace all runners bei their *-latest counterpart
  • Only use parity-large to build llvm now. All other jobs use github runners

@athei athei requested a review from xermicus February 28, 2025 11:29
Copy link
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice

@athei athei merged commit 2fb8bee into paritytech:main Feb 28, 2025
10 checks passed
@athei athei deleted the at/winllvm branch February 28, 2025 14:06
@xermicus xermicus mentioned this pull request Mar 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants