Skip to content

Conversation

pkhry
Copy link
Contributor

@pkhry pkhry commented Mar 17, 2025

Description

Adds --supported-solc-versions cli command to return a semver range of supported solc versions.
Is a hack until #162 is implemented.

@pkhry pkhry requested a review from xermicus March 17, 2025 12:02
Copy link
Member

@xermicus xermicus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM modulo a nit

@xermicus
Copy link
Member

Is a hack until #162 is implemented.

Wait, so why aren't we just implementing #162 then?

@xermicus
Copy link
Member

@pkhry I don't think the feature is invasive. Can you please add a changelog entry? Then it's good for merging. Please just also implement #162

@xermicus xermicus merged commit 36ea69b into main Mar 19, 2025
10 checks passed
@xermicus xermicus deleted the pkhry/supported-versions-cmd branch March 19, 2025 15:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants