Skip to content

Conversation

xermicus
Copy link
Member

@xermicus xermicus commented Mar 18, 2025

No observable changes w.r.t. YUL compilation.

  • Mark solc v0.8.29 as the latest supported version
  • Add integration test for solc v0.8.29 specific feature
  • Use the latest version on CI
  • Drive-by fix linter complaints and a two types in the CI yaml files

Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
Signed-off-by: Cyrill Leutwiler <[email protected]>
@smiasojed
Copy link
Collaborator

Please update the solidity version for wasm compiler.
Just grep for 0.8.28 in revive/js dir.

Signed-off-by: xermicus <[email protected]>
@xermicus
Copy link
Member Author

Good catch, thanks!

pull_request:
branches: ["main"]
types: [opened, synchronize, labled, unlabled]
types: [opened, synchronize, labeled, unlabeled]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was going mad why this shit wasn't working lol.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah as obscure as it gets, I only caught it because of the VS code extension complained about it

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah why isn't it an error to use non existent types :(

Signed-off-by: xermicus <[email protected]>
@xermicus xermicus merged commit 4a9b651 into main Mar 18, 2025
7 of 10 checks passed
@xermicus xermicus deleted the cl/solc-0.8.29 branch March 18, 2025 12:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants