Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(deps): update all non polkadot-js deps in root & docs folder #1475

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

Imod7
Copy link
Contributor

@Imod7 Imod7 commented Aug 14, 2024

Deps update in root folder

Updated the following dependencies to new minor and patch versions in ./package.json:

  • confmgr which should resolve one out of the three open security alerts, the yaml one.
  • lru-cache upgraded only to the latest minor release to avoid any breaking changes in Sidecar.
  • prom-client
  • winston

Updated the following devDependencies to new patch versions:

  • @types/express-serve-static-core

Deps update in docs folder

Updated the following dependencies to new major/breaking versions in docs/package.json:

  • css-loader
  • style-loader
  • swagger-ui
  • yaml-loader

Updated the following devDependencies to new major/breaking and minor versions:

  • copy-webpack-plugin
  • html-webpack-plugin
  • webpack
  • webpack-cli
  • webpack-dev-server

A lot of breaking changes in the docs deps but I checked all of them and they are compatible with the minimum node.js version that we have Sidecar and also the minimum webpack version.

Updated webpack.config

Update needed after upgrading yaml-loader since it introduced a breaking change in v7.0.0 - related PR

This PR switches the loader's output to be stringified JavaScript, and adds a new option asJSON to restore the previous JSON output.

This is necessary otherwise the docs are not rendered and they are giving an error message instead.

Credits / Thanks

  • @TarikGul for highlighting the lru-cache issue related to the node version compatibility if updated to major version
  • @chevdor for doing a new release for confmgr so we can update it also in Sidecar and resolve the security alert

@Imod7 Imod7 requested a review from a team as a code owner August 14, 2024 16:57
@Imod7 Imod7 merged commit c766c1d into master Aug 14, 2024
15 checks passed
@Imod7 Imod7 deleted the domi-update-deps branch August 14, 2024 19:00
rlemaitre-ledger pushed a commit to rlemaitre-ledger/substrate-api-sidecar that referenced this pull request Sep 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants