chore: update Dependabot versioning strategy #1543
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current Setup
After reviewing this Dependabot PR #1534, I noticed that Dependabot does not update the
package.json
file. This is the expected behaviour since polkadot deps are using the caret^
in package.json and Dependabot does not need to update it (default Dependabot versioning is auto).Example
package.json
has a dependency in some version"example-dep": "^14.1.1"
14.x.x
version so14.2.2
or14.1.3
package.json
since it is a compatible version with the range that it is shown inpackage.json
.Proposed Change
Explicitly set Dependabot's
versioning-strategy
toincrease
which will update also the version in package.json even if it is in the compatible range.Example
package.json
even if it is a compatible version / within the range specified in package.json.Reason for this Change
In Sidecar, it is quite important to know the exact versions of polkadot-js dependencies we are using. In the case of issues, the first thing that we do when debugging is to check in
package.json
which version of polkadot deps we are using and then research the changes in the corresponding repos. Even minor or patch releases of polkadot-js packages can affect Sidecar. Therefore, I think its important thatpackage.json
reflects the exact pjs dep versions, so we do not have to check theyarn.lock
every time to verify this.Alternative Solution
I think we would have the same result if we remove the carets from the polkadot js deps. Example from asset-transfer-api :
package.json
andyarn.lock
even for minor release.