-
Notifications
You must be signed in to change notification settings - Fork 240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(signer): ethereum implementation #1501
Merged
Merged
Changes from 2 commits
Commits
Show all changes
19 commits
Select commit
Hold shift + click to select a range
c109482
feat(signer): ethereum implementation
ryanleecode e500d75
fix: wasm tests
ryanleecode 5bb6b17
updates
ryanleecode 3662da7
remove from private key hex
ryanleecode 2590e51
rename signer to subxt signer
ryanleecode 337c192
remove unnecessary super usage
ryanleecode d9f8398
create internal verify in ecdsa and move to separate submodule
ryanleecode c9e916c
remove eth error struct
ryanleecode bf514d8
fix dev accounts and account derivation
ryanleecode c666212
Merge remote-tracking branch 'origin/master' into feat/signer/eth
ryanleecode 15a6492
fix clippy
ryanleecode d4018a6
moar tests
ryanleecode 22e2a21
fixes
ryanleecode 1852a5b
replace eth checksum depedency
ryanleecode 89931d5
add checksum implementation
ryanleecode 92a6e8a
fix: wasm-tests
ryanleecode ff84def
Merge branch 'master' into feat/signer/eth
jsdw 430b001
Tweaks to eth signer (#1526)
jsdw e53b1a3
Merge branch 'master' into feat/signer/eth
ryanleecode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder whether this should be a default feature because I reckon "eth accounts/signer" is rather niche use case and most users won't need it.
Doesn't matter that much it's easy to opt-out anyway, @jsdw thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The only reason I tend to default to having all feature flags is for nicer IDE/docs support (otherwise loads of stuff is greyed out). So this is consistent with what I did with the other signers, but I'd be very open to figuring out an approach which has IDEs/docs working nicely even without feature flags enabled here; I just haven't given it any thought :)