-
-
Notifications
You must be signed in to change notification settings - Fork 600
ci: Fix flaky test #2859
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: Fix flaky test #2859
Conversation
|
🚀 Thanks for opening this pull request! |
📝 WalkthroughWalkthroughA test modification in ParseLiveQueryTest.js removes a sleep delay and explicit subscription cleanup. The test now retains the subscription active without an intermediate wait or manual unsubscribe call, simplifying the teardown sequence. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes 🚥 Pre-merge checks | ✅ 2 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (2 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
💤 Files with no reviewable changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## alpha #2859 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 64 64
Lines 6222 6222
Branches 1489 1473 -16
=========================================
Hits 6222 6222 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR fixes a flaky test in the Parse LiveQuery test suite by removing unnecessary cleanup operations that were causing timeout issues.
Changes:
- Removed a sleep delay and premature unsubscribe call that were causing the test to timeout intermittently
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This change has been released in version 8.0.1 |
Pull Request
Issue
https://github.com/parse-community/Parse-SDK-JS/actions/runs/20796063682/job/59729775728
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.