Skip to content

Conversation

@dplewis
Copy link
Member

@dplewis dplewis commented Jan 8, 2026

Pull Request

Issue

https://github.com/parse-community/Parse-SDK-JS/actions/runs/20796063682/job/59729775728

Parse LiveQuery can subscribe to query with watch
  - Error: Timeout - Async function did not complete within 20000ms (set by jasmine.DEFAULT_TIMEOUT_INTERVAL)

Summary by CodeRabbit

  • Tests
    • Simplified test cleanup flow in live query testing.

✏️ Tip: You can customize this high-level summary in your review settings.

@parse-github-assistant
Copy link

🚀 Thanks for opening this pull request!

@coderabbitai
Copy link

coderabbitai bot commented Jan 8, 2026

📝 Walkthrough

Walkthrough

A test modification in ParseLiveQueryTest.js removes a sleep delay and explicit subscription cleanup. The test now retains the subscription active without an intermediate wait or manual unsubscribe call, simplifying the teardown sequence.

Changes

Cohort / File(s) Summary
Test cleanup simplification
integration/test/ParseLiveQueryTest.js
Removed 2 lines: eliminated sleep(1000) delay and subsequent subscription.unsubscribe() call, altering test teardown flow to keep subscription active longer

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

🚥 Pre-merge checks | ✅ 2 | ❌ 1
❌ Failed checks (1 inconclusive)
Check name Status Explanation Resolution
Description check ❓ Inconclusive The description includes the required Issue section with a CI failure link and error details, but is missing the Approach section explaining what was changed and the Tasks section checklist. Add an Approach section explaining the fix (removal of sleep and unsubscribe) and complete the Tasks section checklist to clarify what was done.
✅ Passed checks (2 passed)
Check name Status Explanation
Title check ✅ Passed The title 'ci: Fix flaky test' accurately reflects the main change—fixing a timeout issue in a flaky test—and directly relates to the changeset.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between cf2ef13 and 0a96c4e.

📒 Files selected for processing (1)
  • integration/test/ParseLiveQueryTest.js
💤 Files with no reviewable changes (1)
  • integration/test/ParseLiveQueryTest.js
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: build (Node 24, 24.1.0)
  • GitHub Check: build (Node 20, 20.19.0)
  • GitHub Check: build (Node 22, 22.12.0)

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@parseplatformorg
Copy link
Contributor

parseplatformorg commented Jan 8, 2026

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@codecov
Copy link

codecov bot commented Jan 8, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4f44412) to head (1aac6db).
⚠️ Report is 6 commits behind head on alpha.

Additional details and impacted files
@@            Coverage Diff            @@
##             alpha     #2859   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         6222      6222           
  Branches      1489      1473   -16     
=========================================
  Hits          6222      6222           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes a flaky test in the Parse LiveQuery test suite by removing unnecessary cleanup operations that were causing timeout issues.

Changes:

  • Removed a sleep delay and premature unsubscribe call that were causing the test to timeout intermittently

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mtrezza mtrezza merged commit 8cb510c into parse-community:alpha Jan 10, 2026
19 checks passed
@dplewis dplewis deleted the flaky-lq-watch branch January 10, 2026 13:05
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 8.0.1

@parseplatformorg parseplatformorg added the state:released Released as stable version label Jan 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

state:released Released as stable version

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants