-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Extract chart visualization feature from PR #2867 #3102
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the You can disable this status message by setting the Comment |
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
Extract core chart visualization feature with minimal changes: - Add ChartVisualization component for displaying bar/line/pie charts - Add DraggableResizablePanel for resizable chart panel - Integrate chart button in Toolbar next to stats - Update DataBrowser to support chart panel state and rendering - Add chart-related dependencies (chart.js, react-chartjs-2, date-fns) - Support selecting Number, Date, and String columns for visualization This is a clean extraction containing ONLY the chart visualization feature from PR #2867, without the unrelated changes that caused rebase issues. Co-authored-by: mtrezza <[email protected]>
- Add missing line breaks between function declarations - Fix French comment to English - Remove commented-out CSS code Co-authored-by: mtrezza <[email protected]>
|
closed in favor of #3110 |
New Pull Request Checklist
Issue Description
PR #2867 contains 194 files changed due to rebase conflicts, mixing the chart visualization feature with unrelated changes (line endings, workflows, package bumps). This PR extracts only the chart feature.
Approach
New Components
ChartVisualization- Renders bar/line/pie charts for selected cells with time series supportDraggableResizablePanel- Reusable draggable/resizable containerModified Components
Toolbar- Added chart toggle button next to stats dropdownDataBrowser- Chart panel state management, renders visualization whenselectedData.length > 1BrowserToolbar- Passes chart props through to ToolbarData Selection
handleCellClickto accept Number, Date, String columns (not just Number)Dependencies
[email protected],[email protected],[email protected],[email protected]Result: 10 files changed (vs. 194), webpack builds clean, CodeQL passes.
TODOs before merging
Warning
Firewall rules blocked me from connecting to one or more addresses (expand for details)
I tried to connect to the following addresses, but was blocked by firewall rules:
googlechromelabs.github.io/usr/local/bin/node node install.mjs(dns block)https://api.github.com/repos/parse-community/parse-dashboard/pulls/2867/usr/bin/curl curl -s REDACTED(http block)https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.94/linux64/chrome-headless-shell-linux64.zip/usr/local/bin/node node install.mjs(http block)https://storage.googleapis.com/chrome-for-testing-public/138.0.7204.94/linux64/chrome-linux64.zip/usr/local/bin/node node install.mjs(http block)If you need me to access, download, or install something from one of these locations, you can either:
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.