Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): Remove prettier quoted argument to fix issue on Windows #7489

Merged
merged 2 commits into from
Aug 14, 2021

Conversation

sadortun
Copy link
Contributor

New Pull Request Checklist

Issue Description

Windows doesn't like single quotes around prettier arguments.

> prettier --write '{src,spec}/{**/*,*}.js'
[error] No files matching the pattern were found: "'{src,spec}/{**/*,*}.js'".

Related issue: #7419 (comment)

Approach

TODOs before merging

@mtrezza
Copy link
Member

mtrezza commented Aug 12, 2021

Do we need any quotes at all? In your comment you wrote that removing the quotes fixed the issue for windows. If it also works for Unix we can just remove then.

@sadortun
Copy link
Contributor Author

@mtrezza Ahah, yes, reading back my old comments 😆

✅ Fixed

@sadortun sadortun changed the title Double-Quote prettier argument to fix issue on Windows Remove prettier quoted argument to fix issue on Windows Aug 12, 2021
@dblythy
Copy link
Member

dblythy commented Aug 13, 2021

This likely applies to the example repo too

@mtrezza
Copy link
Member

mtrezza commented Aug 13, 2021

Well spotted, could someone open a PR there if necessary?

Copy link
Member

@mtrezza mtrezza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested npm run prettier without brackets on unix and it works fine.

Thanks for the fix!

@mtrezza mtrezza changed the title Remove prettier quoted argument to fix issue on Windows chore(ci): Remove prettier quoted argument to fix issue on Windows Aug 13, 2021
@codecov
Copy link

codecov bot commented Aug 13, 2021

Codecov Report

Merging #7489 (c40fb8a) into master (8fddac3) will decrease coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7489      +/-   ##
==========================================
- Coverage   93.96%   93.93%   -0.04%     
==========================================
  Files         181      181              
  Lines       13271    13271              
==========================================
- Hits        12470    12466       -4     
- Misses        801      805       +4     
Impacted Files Coverage Δ
src/batch.js 91.37% <0.00%> (-1.73%) ⬇️
src/Adapters/Storage/Mongo/MongoStorageAdapter.js 92.37% <0.00%> (-0.66%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fddac3...c40fb8a. Read the comment docs.

@mtrezza
Copy link
Member

mtrezza commented Aug 13, 2021

I just notice that it says "This branch is out-of-date with the base branch". Can you rebase?

@sadortun
Copy link
Contributor Author

@mtrezza Updated

@mtrezza mtrezza merged commit c66a39f into parse-community:master Aug 14, 2021
@mtrezza
Copy link
Member

mtrezza commented Aug 14, 2021

Merged - thanks for this PR!

@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0-beta.1

@parseplatformorg parseplatformorg added the state:released-beta Released as beta version label Nov 1, 2021
@parseplatformorg
Copy link
Contributor

🎉 This change has been released in version 5.0.0

@parseplatformorg parseplatformorg added the state:released Released as stable version label Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state:released Released as stable version state:released-beta Released as beta version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants