Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to copy button #332

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Koustavd18
Copy link
Contributor

Description
The copy button is visible when a cell is empty in the logs view.
For in-secure context(HTTP) copy button is visible even though the clipboard is not accessible.

FIXES

  • Copy button wont be visible when the cell value is empty in the logs table
  • copy button and copy action will not be available for in-secure sessions

src/pages/Stream/Views/Explore/JSONView.tsx Outdated Show resolved Hide resolved
src/pages/Stream/Views/Explore/JSONView.tsx Outdated Show resolved Hide resolved
src/pages/Stream/Views/Explore/StaticLogRow.tsx Outdated Show resolved Hide resolved
@balaji-jr
Copy link
Contributor

  1. And we also need to handle the pop-up opening up on the right when selecting text.
  2. The same logic is required and should be implemented everywhere else. (Log info popup, stream info section etc ...)

src/layouts/MainLayout/index.tsx Outdated Show resolved Hide resolved
src/layouts/MainLayout/providers/AppProvider.tsx Outdated Show resolved Hide resolved
src/pages/Stream/Views/Explore/JSONView.tsx Outdated Show resolved Hide resolved
src/pages/Stream/Views/Explore/JSONView.tsx Outdated Show resolved Hide resolved
src/pages/Stream/Views/Explore/JSONView.tsx Outdated Show resolved Hide resolved
src/pages/Stream/Views/Explore/StaticLogTable.tsx Outdated Show resolved Hide resolved
src/pages/Stream/Views/Explore/StaticLogTable.tsx Outdated Show resolved Hide resolved
@balaji-jr
Copy link
Contributor

As previously mentioned in #332 (comment),

These 2 things are still not addressed.

@Koustavd18 Koustavd18 self-assigned this Sep 30, 2024
@Koustavd18 Koustavd18 marked this pull request as draft September 30, 2024 15:17
@Koustavd18 Koustavd18 marked this pull request as ready for review September 30, 2024 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants