refactor: clean up parts of the codebase #981
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
de-sh
commented
Nov 2, 2024
de-sh
commented
Nov 2, 2024
| // Create the HTTP server | ||
| let http_server = HttpServer::new(create_app_fn) | ||
| .workers(num_cpus::get()) | ||
| .shutdown_timeout(60); |
There was a problem hiding this comment.
what should be shutdown timeout?
| // Create the HTTP server | ||
| let http_server = HttpServer::new(create_app_fn) | ||
| .workers(num_cpus::get()) | ||
| .shutdown_timeout(60); |
| // Create the HTTP server | ||
| let http_server = HttpServer::new(create_app_fn) | ||
| .workers(num_cpus::get()) | ||
| .shutdown_timeout(120); |
| // Create the HTTP server | ||
| let http_server = HttpServer::new(create_app_fn) | ||
| .workers(num_cpus::get()) | ||
| .shutdown_timeout(60); |
There was a problem hiding this comment.
What'd be the right value?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #XXXX.
Description
I am trying to figure out the codebase and applying some refactors that are focused at improving the readability and DRYing.
This PR has: