-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added support for visualising the Tree #40
base: master
Are you sure you want to change the base?
Conversation
@parthsarthi03 please review as and when you get waqt |
@parthsarthi03 Reminding |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd want to avoid adding extra dependencies. Rest looks good, could we also have a readme section on how to visualize.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we please keep the extra dependencies added to a minimum requirements.txt? It might be better to have separate instructions to install the libraries needed for the visualization.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ack, I have added support to download the needed igraph
and plotly
when the user needs it.
Have added instructions in both |
@parthsarthi03 please look once whenever free |
@jalotra Thanks for the great work! I was running it for the sample story, but there seems to be a bug, the root index 34, is becoming a parent note of the -1 index node (see screenshot below). Also, not a blocker but a great feature to have would be layer no. displayed with a different color for each layer. |
hello hello, this is a plotly thing where they sometimes visually mark up the child on top if space is limited, but rest assured that node is child. |
Solves #36
How to test, have written a sample test in :
Example Image generated with test :