Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for visualising the Tree #40

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

jalotra
Copy link

@jalotra jalotra commented May 15, 2024

Solves #36

How to test, have written a sample test in :

python3 -m raptor.tests.visualise_tree_test

Example Image generated with test :
image

@jalotra
Copy link
Author

jalotra commented May 15, 2024

@parthsarthi03 please review as and when you get waqt

@jalotra
Copy link
Author

jalotra commented May 22, 2024

@parthsarthi03 Reminding

Copy link
Owner

@parthsarthi03 parthsarthi03 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd want to avoid adding extra dependencies. Rest looks good, could we also have a readme section on how to visualize.

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we please keep the extra dependencies added to a minimum requirements.txt? It might be better to have separate instructions to install the libraries needed for the visualization.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ack, I have added support to download the needed igraph and plotly when the user needs it.

@jalotra
Copy link
Author

jalotra commented May 23, 2024

I'd want to avoid adding extra dependencies. Rest looks good, could we also have a readme section on how to visualize.

Have added instructions in both Readme and demo.ipynb on how to use visualisation using plotly.

@jalotra
Copy link
Author

jalotra commented May 24, 2024

@parthsarthi03 please look once whenever free

@parthsarthi03
Copy link
Owner

@jalotra Thanks for the great work! I was running it for the sample story, but there seems to be a bug, the root index 34, is becoming a parent note of the -1 index node (see screenshot below).

Also, not a blocker but a great feature to have would be layer no. displayed with a different color for each layer.

Screen Shot 2024-05-29 at 3 37 36 PM

@jalotra
Copy link
Author

jalotra commented May 30, 2024

hello hello, this is a plotly thing where they sometimes visually mark up the child on top if space is limited, but rest assured that node is child.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants