[v1] Delete sprout-generated AST; remove v1 from AST package path
#1639
Conversation
| @@ -55,24 +55,3 @@ publish { | |||
| name = "PartiQL AST" | |||
| description = "PartiQL's Abstract Syntax Tree" | |||
| } | |||
|
|
|||
| val generate = tasks.register<Exec>("generate") { | |||
There was a problem hiding this comment.
(self-review) remove sprout-generation from AST build
There was a problem hiding this comment.
This is huge, thank you so much!
| @@ -69,6 +69,8 @@ public <R, C> R accept(@NotNull AstVisitor<R, C> visitor, C ctx) { | |||
| @Builder(builderClassName = "Builder") | |||
| @EqualsAndHashCode(callSuper = false) | |||
| public static class StructWildcard extends ExcludeStep { | |||
| public StructWildcard() {} | |||
There was a problem hiding this comment.
(self-review) public constructors were missing fro ExcludeStep.StructWildcard and ExcludeStep.CollWildcard.
| /** | ||
| * Basic printer for debugging during early development lifecycle | ||
| */ | ||
| internal object AstPrinter { |
There was a problem hiding this comment.
(self-review) this CLI object used the sprout-generated AST but it was unused.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## v1-migrate-ast-sqldialect #1639 +/- ##
============================================================
Coverage ? 80.03%
Complexity ? 47
============================================================
Files ? 19
Lines ? 506
Branches ? 23
============================================================
Hits ? 405
Misses ? 88
Partials ? 13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
CROSS-ENGINE-REPORT ❌
Testing Details
Result Details
Now FAILING Tests ❌The following 3 test(s) were previously PASSING in BASE but are now FAILING in TARGET: Click here to see
Now IGNORED Tests ❌The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. Now Passing Tests180 test(s) were previously failing in BASE (LEGACY-V0.14.8) but now pass in TARGET (EVAL-03CA641). Before merging, confirm they are intended to pass. The complete list can be found in GitHub CI summary, either from Step Summary or in the Artifact. CROSS-COMMIT-REPORT ✅
Testing DetailsResult Details
|
| @@ -55,24 +55,3 @@ publish { | |||
| name = "PartiQL AST" | |||
| description = "PartiQL's Abstract Syntax Tree" | |||
| } | |||
|
|
|||
| val generate = tasks.register<Exec>("generate") { | |||
There was a problem hiding this comment.
This is huge, thank you so much!
alancai98
force-pushed
the
v1-migrate-ast-delete-sprout-ast
branch
from
290262e
to
1289a9b
Compare
Relevant Issues
Description
v1from AST package pathOther Information
Updated Unreleased Section in CHANGELOG: [NO]
Any backward-incompatible changes? [YES]
Any new external dependencies? [NO]
Do your changes comply with the Contributing Guidelines
and Code Style Guidelines? [NO]
License Information
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.