Add Cargo.lock file #26
Merged
+55
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
Using `cargo generate-lockfile`, as recommended in: https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control
Byron
approved these changes
Aug 26, 2025
There was a problem hiding this comment.
That's a great idea, thanks!
gitoxide does the same for determinism on CI, even though here it might be not quite as clear-cut whether Cargo.lock is truly needed.
Let's leave the decision to @pascalkuthe for merging or closing.
|
Having a Cargo.lock would make my life easier packaging this application for Flathub: |
|
I am fine with adding it but I think any package manager that relies on the repo for a librarybl having thr lock file is doing something wrong. Imara-diff is a library and therefore the lockfile for any actual build will come from the application and not this repo (and can have different semvar conoativle versions) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As recommended in:
https://doc.rust-lang.org/cargo/faq.html#why-have-cargolock-in-version-control