Skip to content

Conversation

Hawk777
Copy link
Contributor

@Hawk777 Hawk777 commented Aug 11, 2025

No description provided.

Byron
Byron previously approved these changes Aug 12, 2025
Copy link
Collaborator

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot, great catches!

@Byron
Copy link
Collaborator

Byron commented Aug 12, 2025

@pascalkuthe We'd need your help here - there is a clippy fix without which no PR will be able to merge, and I can't self-approve.

The alternative should be that @Hawk777 closes #29 and puts that commit here, to mine isn't the topmost one anymore, maybe?
Of course, I could also remove the fix and just merge as master is broken right now as well, so no harm would be done, but maybe we try one at a time.

@Hawk777
Copy link
Contributor Author

Hawk777 commented Aug 12, 2025

If the fix to the Clippy lint can go into master, I can rebase both my branches.

@Hawk777
Copy link
Contributor Author

Hawk777 commented Aug 12, 2025

Your fix looks reasonable to me, but as I’m not a maintainer of this repo, I probably shouldn’t bypass the rules by cherry-picking it into my branch or doing other similar hacks.

@Byron
Copy link
Collaborator

Byron commented Aug 12, 2025

This setting is just a maintenance hassle - if I wanted to mess with the repo I could just use another account and merge whatever I want, right?

@Hawk777 It seems like if you would push last, for instance by fixing clippy, I can merge this.

@Hawk777
Copy link
Contributor Author

Hawk777 commented Aug 16, 2025

@Byron alright, I think it’s trivial enough that I’m fine with cherry-picking your commit into a PR of my own, which is GH-30 (I’ll rebase my other two after it’s merged). With respect to “This setting is just a maintenance hassle - if I wanted to mess with the repo I could just use another account and merge whatever I want, right?” it makes sense if someone has commit access but doesn’t have the ability to grant other people access; then they couldn’t add a second of their own accounts, so they’d be forced to follow the rule.

@Byron
Copy link
Collaborator

Byron commented Aug 16, 2025

You can supersede this PR with a new one that doesn't contain my commit.

@Hawk777
Copy link
Contributor Author

Hawk777 commented Aug 16, 2025

This PR already doesn’t contain your commit. I’ll just rebase it.

Copy link
Collaborator

@Byron Byron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Byron
Copy link
Collaborator

Byron commented Aug 17, 2025

It must be a new PR, this one is tainted.

Screenshot 2025-08-17 at 04 48 38

@Hawk777 Hawk777 closed this Aug 17, 2025
@Hawk777 Hawk777 mentioned this pull request Aug 17, 2025
@Hawk777
Copy link
Contributor Author

Hawk777 commented Aug 17, 2025

Recreated as GH-31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants