fix is_odd condition to ensure optimal number of iterations are used│ #36
+87
−6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
closes #32 should slightly reduce number of iterations during diffing and therefore slightly speedup the diff. May change the results slightly in edgecase (but overall the old results where still correct, this would only affect edgecases with multiple correct results, very unlikely to be noticed in practice)
Byron
reviewed
Oct 5, 2025
Comment on lines
+158
to
+162
| // if the check for is_odd incorrectly always true then we take a fastpath | ||
| // when we shouldn't which always leads to inifite iterations/recursion | ||
| // still we check the number of iterations here in case the search | ||
| // is buggy in more subtle ways | ||
| cov_mark::check_count!(SPLIT_SEARCH_ITER, 15); |
There was a problem hiding this comment.
I am loving these tests! TIL cov_mark - very useful.
|
Nothing really just wanted you to be aware and CI to pass. I think backporting this should be easy as it's just a 1-line change (the myers diff is exactly the same as 0.1). The tests would need extra work but considering how small of a change this is it may not be necessary to backport those |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #32
Should slightly reduce number of iterations (one less search step which results in up to 2d search iterations) during diffing and therefore speedup the diff a bit. May change the results slightly in edgecase but overall the old results where still correct, this would only affect edgecases with multiple correct results, very unlikely to be noticeable in practice.