-
Notifications
You must be signed in to change notification settings - Fork 32
chore: Remove chain-spec-generator #296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Remove chain-spec-generator #296
Conversation
|
waiting for r0gue-io/pop-cli#687 |
|
|
||
| - name: Install pop | ||
| run: | | ||
| cargo install --git https://github.com/r0gue-io/pop-cli.git --branch main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what about the following?
export NONINTERACTIVE=1
curl -fsSL https://raw.githubusercontent.com/Homebrew/install/HEAD/install.sh | bash
brew install r0gue-io/pop-cli/pop
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's also possible that the ubuntu host already has hombrew installed 🤔 .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't brew installing the latest release?
We'll need pop 0.11.0 for this, so til it's released we should use the main branch. After that we can use brew yep
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh, OK then 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
While I agree that we are better of removing the chain-spec-generator, I'm not sure if we should do it right now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy with the current status after discussing with @tsenovilla by DMs
Remove chain-spec-generator and build chain specs using
pop🔗 zboto Link