Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete wait v2 #3

Open
wants to merge 36 commits into
base: master
Choose a base branch
from
Open

Delete wait v2 #3

wants to merge 36 commits into from

Conversation

pasha-codefresh
Copy link
Owner

Note on DCO:

If the DCO action in the integration test fails, one or more of your commits are not signed off. Please click on the Details link next to the DCO action for instructions on how to resolve this.

Checklist:

  • Either (a) I've created an enhancement proposal and discussed it with the community, (b) this is a bug fix, or (c) this does not need to be in the release notes.
  • The title of the PR states what changed and the related issues number (used for the release note).
  • I've included "Closes [ISSUE #]" or "Fixes [ISSUE #]" in the description to automatically close the associated issue.
  • I've updated both the CLI and UI to expose my feature, or I plan to submit a second PR with them.
  • Does this PR require documentation updates?
  • I've updated documentation as required by this PR.
  • Optional. My organization is added to USERS.md.
  • I have signed off all my commits as required by DCO
  • I have written unit and/or e2e tests for my change. PRs without these are unlikely to be merged.
  • My build is green (troubleshooting builds).

adamjohnson01 and others added 30 commits October 27, 2019 20:05
@adamjohnson01
Add wait and timeout flags to app delete cmd
edb664f
@adamjohnson01
switch to using waitOnApplicationStatus
5070a20
@adamjohnson01
add examples to app delete
1f053cb
@adamjohnson01
remove goroutine
a3d3c3f
@adamjohnson01
remove println
680a1a6
@adamjohnson01
Merge branch 'master' of https://github.com/argoproj/argo-cd into del…
1dc4052 
…ete-wait
@adamjohnson01
Merge branch 'master' of https://github.com/argoproj/argo-cd into del…
0a92910 
…ete-wait
@adamjohnson01
Merge branch 'master' of https://github.com/argoproj/argo-cd into del…
e84de89 
…ete-wait
@adamjohnson01
Merge branch 'master' of https://github.com/argoproj/argo-cd into del…
c823cee 
…ete-wait
@adamjohnson01
Merge branch 'master' of https://github.com/argoproj/argo-cd into del…
0f303ea 
…ete-wait
@adamjohnson01
Merge branch 'delete-wait' of https://github.com/wintoncode/argo-cd i…
d972383 
…nto delete-wait
@adamjohnson01
Merge branch 'master' of https://github.com/argoproj/argo-cd into del…
6184f1c 
…ete-wait
@adamjohnson01
Merge branch 'delete-wait' of https://github.com/wintoncode/argo-cd i…
3c18b49 
…nto delete-wait
@adamjohnson01
add e2e test for app delete wait
cd7c943
@adamjohnson01
fix linting issue
9ccfa64
@adamjohnson01
Merge branch 'master' of https://github.com/argoproj/argo-cd into del…
02c7372 
…ete-wait
@pasha-codefresh
delete wait refreshing pr
0226668 
Signed-off-by: pashavictorovich <[email protected]>
@wd @pasha-codefresh
feat: Expose ARGOCD_APP_NAME to the kustomize build command (argopr…
0038806 
…oj#8096)

Signed-off-by: Dong Wang <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@pasha-codefresh
feat: Use encrypted cookie to store OAuth2 state nonce (instead of re…
69536bb 
…dis) (argoproj#8241)

feat: Use encrypted cookie to store OAuth2 state nonce (instead of redis) (argoproj#8241)

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@pasha-codefresh
chore: upgrade gitops engine (argoproj#8288)
5f8fb65 
Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@pasha-codefresh
Revert "chore: Run dex reverse proxy only when dex is configured (arg…
b1490e5 
…oproj#7999)" (argoproj#8291)

This reverts commit 303cc46.

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@Snaipe @pasha-codefresh
docs: update ambassador mappings to avoid --grpc-web-root-path (argop…
c169b8a 
…roj#8028)

I found it non-intuitive to have to tell our users to use `--grpc-web-root-path /`
when logging in when the defaults should have just worked.

This commit updates the Host-based ambassador mappings to avoid that, making
plain `argocd login <host>` calls work.

Signed-off-by: Franklin "Snaipe" Mathieu <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@crenshaw-dev @pasha-codefresh
chore: fix docs formatting (argoproj#8293)
bd2e461 
Signed-off-by: Michael Crenshaw <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@pasha-codefresh
chore: update slack version (argoproj#8299)
c99c238 
chore: update slack version (argoproj#8299)

Signed-off-by: pashavictorovich <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@keithchong @pasha-codefresh
feat: Zoom in and out on resource view (argoproj#7183) (argoproj#8290)
cb60c49 
Signed-off-by: Keith Chong <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@wadason @pasha-codefresh
docs: Add ZOZO to list of users (argoproj#8300)
313a62e 
Signed-off-by: keisuke.wada <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@guilhem @pasha-codefresh
chore(bug_report): put instructions in comment (argoproj#8283)
422db25 
Users reporting a bug will see instructions, can keep it, it will be ignored in final issue

Signed-off-by: Guilhem Lettron <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@terrytangyuan @pasha-codefresh
docs: Add link to new blog (argoproj#8308)
855930c 
Signed-off-by: Yuan Tang <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@yujunz @alexmt @pasha-codefresh
fix: fetch revision only then fallback to default refspec (argoproj#5605
7c75fc2 
)

* fix: fallback to fetch default only on error

Ignoring commit SHA breaks gerrit when the commit is not merged

Signed-off-by: Yujun Zhang <[email protected]>

* revert util/git/client.go changes

Signed-off-by: Alexander Matyushentsev <[email protected]>

Co-authored-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@pasha-codefresh
fix: add missing steps in release workflow to setup docker buildx (ar…
c492130 
…goproj#8311)

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
saumeya and others added 6 commits February 2, 2022 16:22
@saumeya @pasha-codefresh
feat: favourite ui feature (argoproj#8210)
99d3e36 
* feat: favourite ui feature (argoproj#8210)

Signed-off-by: saumeya <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@pasha-codefresh
fix: argocd build fails on windows (argoproj#8319)
804edd8 
Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@pasha-codefresh
docs: mention argocd notifications and applicationset changes in upgr…
78e6cce 
…ade instructions (argoproj#8312)

Signed-off-by: Alexander Matyushentsev <[email protected]>
Signed-off-by: pashavictorovich <[email protected]>
@adamjohnson01 @pasha-codefresh
add e2e test for app delete wait
99abb36 
Signed-off-by: pashavictorovich <[email protected]>
@adamjohnson01 @pasha-codefresh
fix linting issue
6aada27 
Signed-off-by: pashavictorovich <[email protected]>
@pasha-codefresh
Merge remote-tracking branch 'origin/delete-wait' into delete-wait
16bb7c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.