Fix bugs below 10 WPM #37
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix pasky#36 Before, lowering the WPM below 10 would make it only possible to crash the program by lowering all the way to zero; now, the WPM is capped above zero, rises by one until ten, and pauses when lowering below one. It is reasonably intuitive and an edge case anyways.
|
I don't consider this LGTM, it is incredibly hackish and does not configure the dense text behavior reliably for someone who would want to configure the slow reading behavior from toplevel variables. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #36
Before, lowering the WPM below 10 would make it only possible to crash the program by lowering all the way to zero; now, the WPM is capped above zero, rises by one until ten, and pauses when lowering below one. It is reasonably intuitive and an edge case anyways.