(PC-32864)[API] script: repair some pricing and event #14961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+7
to
+9
| PRICING_ID = 39405405 | ||
| FINANCE_EVENT_ID = 36594925 | ||
| NEW_VENUE_ID = 127134 |
There was a problem hiding this comment.
je trouve ça étonnant d'avoir un script qui tourne sur des IDs en particulier, tu n'avais pas une requête qui te sortait les objets en état invalide ?
ça t'assure que les objets que tu traites sont bien dans l'état invalide attendu et ça te permet de refaire tourner le script plus tard si d'autres cas sont concernés
| def update_pricing_and_event_venue(not_dry: bool = False) -> None: | ||
| finance_event = finance_models.FinanceEvent.query.filter_by(id=FINANCE_EVENT_ID).one() | ||
| finance_event.venueId = NEW_VENUE_ID | ||
| db.session.add(finance_event) |
There was a problem hiding this comment.
j'ai déjà vu des session.add comme ça sur des objets existants, je me demande à quoi ça sert exactement ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
But de la pull request
Ticket Jira (ou description si BSR) : https://passculture.atlassian.net/browse/PC-32864
Vérifications